fix: close fds when returning due to different file size#8
Open
RafaelKr wants to merge 1 commit intorook2pawn:masterfrom
Open
fix: close fds when returning due to different file size#8RafaelKr wants to merge 1 commit intorook2pawn:masterfrom
RafaelKr wants to merge 1 commit intorook2pawn:masterfrom
Conversation
This really fixes rook2pawn#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 days ago I created #7
I closed the old PR because I thought it didn't completely fix the issue #4 as I ran into another problem related to nodejs/node#30837
But it seems to be working now.